-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add feature to delete bundles, messages, variants #51
Comments
Do we really need to fill required actions in the ui for testing purposes? I would rather give dev mode buttons on the bottom or something like that. |
Ok, we need to make a decision. Should it be possible to create and delete bundles? |
As it is only used for testing, we can add these buttons if the environment variable is set to dev. |
Just add create message and bundles buttons. Fink is standalone now. If someone wants to create a bundle/message/variant, they should be able to do so.
Yes. We want to test change control for inserts and deletions. Users will surely trigger bugs. |
Which user wants that? |
For demo reasons we ourselves want it. There is no reason to not implement this except that back in the day our tech stack didn't allow us to create new messages from sherlock |
If we are the users now. Okey but now real user wants that. |
i remember that users asked for it on discord already. so agree to implement this? |
Ok, let's add it then. |
Another user asked for delete operations in UIs on disord https://discord.com/channels/897438559458430986/1283048712448376873/1283158576960897169. |
It absolutely makes sense for sherlock, not really for fink. But this doesn't need to setup generally. This bundle action can be slotted in the editor so what ever the app prefers can be built. |
Sherlock users have a context in the coding workflow about new bundles that are to be created or old bundles that are to be deleted. Fink users don't have that. |
Let's close this discussion and introduce creation and deletion in FInk for demo purposes and users.
That's a validation rule. |
Okey let's do that 👍 |
Proposal
Add a delete button to variants, messages and bundles.
Context
We can't test change control of creations and deletions otherwise.
cc @martin.lysk1
The text was updated successfully, but these errors were encountered: