Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to delete bundles, messages, variants #51

Open
samuelstroschein opened this issue Sep 5, 2024 — with Linear · 14 comments
Open

add feature to delete bundles, messages, variants #51

samuelstroschein opened this issue Sep 5, 2024 — with Linear · 14 comments

Comments

Copy link
Member

samuelstroschein commented Sep 5, 2024

Proposal

Add a delete button to variants, messages and bundles.

CleanShot 2024-09-05 at 13.53.02@2x.png

Context

We can't test change control of creations and deletions otherwise.

cc @martin.lysk1

@samuelstroschein samuelstroschein changed the title add feature to delete entities add feature to delete bundles, messages, variants Sep 5, 2024
Copy link
Member

Do we really need to fill required actions in the ui for testing purposes? I would rather give dev mode buttons on the bottom or something like that.

Copy link
Member

Ok, we need to make a decision. Should it be possible to create and delete bundles?
Workflow-wise, it makes no sense that translators can create bundles. As it is a standalone app, it kind of makes sense. In other editors create and delete are enabled by roles (translators can't, devs can).

Copy link
Member

As it is only used for testing, we can add these buttons if the environment variable is set to dev.

@samuelstroschein
Copy link
Member Author

Just add create message and bundles buttons. Fink is standalone now. If someone wants to create a bundle/message/variant, they should be able to do so.

Do we really need to fill required actions in the ui for testing purposes?

Yes. We want to test change control for inserts and deletions. Users will surely trigger bugs.

Copy link
Member

If someone wants

Which user wants that?

Copy link
Member Author

For demo reasons we ourselves want it. There is no reason to not implement this except that back in the day our tech stack didn't allow us to create new messages from sherlock

Copy link
Member

If we are the users now. Okey but now real user wants that.

Copy link
Member Author

i remember that users asked for it on discord already. so agree to implement this?

Copy link
Member

Ok, let's add it then.

Copy link
Member Author

Another user asked for delete operations in UIs on disord https://discord.com/channels/897438559458430986/1283048712448376873/1283158576960897169.

Copy link
Member

It absolutely makes sense for sherlock, not really for fink. But this doesn't need to setup generally. This bundle action can be slotted in the editor so what ever the app prefers can be built.

Copy link
Member

Sherlock users have a context in the coding workflow about new bundles that are to be created or old bundles that are to be deleted. Fink users don't have that.
In other i18n tools, they restrict the creation and deletion of messages to the role of the dev/i18n manager. Translators cannot create or delete new bundles as no one wants them to do that. It would simply be unnecessary error potential.
We don't have roles yet, but our personas use different tools. I bet that the introduction of this functionality will eventually lead to requests to disable this feature for translators.

@samuelstroschein
Copy link
Member Author

Let's close this discussion and introduce creation and deletion in FInk for demo purposes and users.

I bet that the introduction of this functionality will eventually lead to requests to disable this feature for translators.

That's a validation rule.

Copy link
Member

Let's close this discussion and introduce creation and deletion in Fink for demo purposes and users.

Okey let's do that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants