Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable Ninja recommendation #43

Open
NiklasBuchfink opened this issue Aug 14, 2024 — with Linear · 2 comments
Open

Option to disable Ninja recommendation #43

NiklasBuchfink opened this issue Aug 14, 2024 — with Linear · 2 comments

Comments

Copy link
Member

Context

In some cases, a maintainer of a project wants to prevent contributors from adding the Ninja action:
https://discord.com/channels/897438559458430986/1219664905167306772/1273290103267000515

Proposal

Add an option to disable the recommendation of Ninja for all Fink users.

As we do not yet have any app-specific options, we need to define how we integrate these (e.g. part of the inlang project?).

Copy link
Member

samuelstroschein commented Aug 14, 2024

how about an external folder that "external parties" can store whatever they need in?

for example, fink could store external/app.fink/settings.json file in the inlang file? same applies to sherlock (cc @felix.haeberle) with a app.sherlock/settings.json file.


.
└── project.inlang/
    ├── external/
    │   ├── app.sherlock/
    │   │   └── settings.json
    │   ├── app.fink/
    │   │   └── settings.json
    │   └── plugin.i18next/
    │       └── settings.json
    └── settings.json

Pros

  • lazy loading of external data (in contrast to putting all settings into inlang settings.json file)
  • apps, plugins, X can save whatever they need)

Cons

  • more structure in the inlang file

@NiklasBuchfink
Copy link
Member Author

I like the structure 👍

cc @NilsJacobsen as we probably want to render these settings into the settings component in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants