Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for D8/R8 #3748

Open
BenHenning opened this issue Aug 31, 2021 · 3 comments
Open

Add support for D8/R8 #3748

BenHenning opened this issue Aug 31, 2021 · 3 comments
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

BenHenning commented Aug 31, 2021 •
edited
Loading

R8 helps augment Proguard by providing Android-specific optimizations that can largely simplify Proguard configurations by properly supporting reflection, among other cases (including better resource shrinking).

Note that Bazel's Android toolchain doesn't currently support R8, but hopefully will sometime next year.
@BenHenning BenHenning mentioned this issue Oct 7, 2021
Merged
6 tasks
@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@BenHenning
Copy link
Member Author

I'm not certain on R8 integration, but I believe we're now using D8 after migrating to Bazel 6.x in #4886 so there shouldn't be anything else to do here.

@github-actions github-actions bot reopened this Aug 30, 2024
@github-actions GitHub Actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/config/proguard/protobuf-proguard-rules.pro

Line 3 in 0ef7a46

# TODO(#3748): Simplify this once R8 is supported.

@BenHenning
Copy link
Member Author

Aha, looks like there's one TODO to address first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Task Force] Migrate to Bazel - Android
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanlip @BenHenning @Broppia