Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI checks are blocked due to Bazel build check failing on forks #2706

Closed
BenHenning opened this issue Feb 12, 2021 · 1 comment · Fixed by #2707
Closed

CI checks are blocked due to Bazel build check failing on forks #2706

BenHenning opened this issue Feb 12, 2021 · 1 comment · Fixed by #2707
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

See #2691 (comment) for context. This was caused by #1904, and I'm going do 1 attempt at fix-forwarding it for timeliness. If that doesn't work, I'll be reverting the original change.
@BenHenning
Copy link
Member Author

Note that I'm choosing fix forward here despite the reversion policy because we can trivially verify correctness in CI (there's no risk for unexpected failures--it either works or doesn't). I'm also making the change on a fork to verify it works now.

@BenHenning BenHenning mentioned this issue Feb 12, 2021
Merged
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Task Force] Migrate to Bazel - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2706: Use a more correct pattern for checking forks BenHenning/oppia-android
1 participant
@BenHenning