Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all the spans rendered in the ui #3428

Open
mostafaleantech opened this issue Feb 4, 2022 · 8 comments
Open

Not all the spans rendered in the ui #3428

mostafaleantech opened this issue Feb 4, 2022 · 8 comments
Labels
bug

Comments

@mostafaleantech
Copy link

Describe the Bug

Hi, I'm not sure if this is a bug or a mis-configuration, I have the following json coming from some spring cloud services and the rendering seems to be missing some spans, the service named main-integration-unit is always not visible, even though it's present in the JSON, can you help me on understanding why or if it's a bug, should we re-open this case?
The Json:

[
    {
        "traceId": "trace123idtrace123id",
        "parentId": "240b231587dbf162",
        "id": "cbdb7f9d44dc83c6",
        "kind": "SERVER",
        "name": "get /api/internal/path1/{someid}",
        "timestamp": 1643375072199270,
        "duration": 137271,
        "localEndpoint": {
            "serviceName": "some-service",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "ipv4": "192.168.183.86",
            "port": 12345
        },
        "tags": {
            "http.method": "GET",
            "http.path": "/api/internal/path1/someid123",
            "mvc.controller.class": "InternalCallsController",
            "mvc.controller.method": "blaById"
        },
        "shared": true
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "6e8f6b3810ec68fd",
        "id": "17343a080f893a68",
        "kind": "CLIENT",
        "name": "post",
        "timestamp": 1643375072381891,
        "duration": 3080081,
        "localEndpoint": {
            "serviceName": "path2-api-service",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "http.method": "POST",
            "http.path": "/path2/path4"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "17343a080f893a68",
        "id": "700082a015d9cd98",
        "kind": "SERVER",
        "name": "post /path2/path4",
        "timestamp": 1643375072384222,
        "duration": 3077527,
        "localEndpoint": {
            "serviceName": "main-integration-unit",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "ipv4": "127.0.0.1",
            "port": 12345
        },
        "tags": {
            "http.method": "POST",
            "http.path": "/path2/path4",
            "mvc.controller.class": "FirstController",
            "mvc.controller.method": "doSomething"
        },
        "shared": true
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "700082a015d9cd98",
        "id": "514caa791673b818",
        "kind": "CLIENT",
        "name": "post",
        "timestamp": 1643375072405999,
        "duration": 3049268,
        "localEndpoint": {
            "serviceName": "main-integration-unit",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "http.method": "POST",
            "http.path": "/path5/rest/api/"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "26640d33d4109f52",
        "id": "01d29d9a99920587",
        "kind": "CONSUMER",
        "name": "poll",
        "timestamp": 1643375075504926,
        "duration": 1,
        "localEndpoint": {
            "serviceName": "webhook-service",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "serviceName": "kafka"
        },
        "tags": {
            "kafka.topic": "com.company.label.created"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "6e8f6b3810ec68fd",
        "id": "26640d33d4109f52",
        "kind": "PRODUCER",
        "name": "send",
        "timestamp": 1643375075503019,
        "duration": 2597,
        "localEndpoint": {
            "serviceName": "path2-api-service",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "serviceName": "kafka"
        },
        "tags": {
            "kafka.topic": "com.company.label.created"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "240b231587dbf162",
        "id": "6e8f6b3810ec68fd",
        "kind": "SERVER",
        "name": "post /v1/path3/path4",
        "timestamp": 1643375072339083,
        "duration": 3167260,
        "localEndpoint": {
            "serviceName": "path2-api-service",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "ipv4": "111.111.1.1"
        },
        "tags": {
            "http.method": "POST",
            "http.path": "/v1/path3/path4",
            "mvc.controller.class": "Somepath2Controller",
            "mvc.controller.method": "doSomthing2"
        },
        "shared": true
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "e15b943cb34bea2a",
        "id": "18b4409a5719aead",
        "kind": "SERVER",
        "name": "get /api/internal/path1/{someid}",
        "timestamp": 1643375075511111,
        "duration": 236651,
        "localEndpoint": {
            "serviceName": "some-service",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "ipv4": "192.168.1.1",
            "port": 12345
        },
        "tags": {
            "http.method": "GET",
            "http.path": "/api/internal/path1/someid123",
            "mvc.controller.class": "InternalCallsController",
            "mvc.controller.method": "getSomethingById"
        },
        "shared": true
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "d16d0ae633f4056f",
        "id": "e15b943cb34bea2a",
        "name": "send-webhook-for-first-time",
        "timestamp": 1643375075509166,
        "duration": 1403716,
        "localEndpoint": {
            "serviceName": "webhook-service",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "class": "WebhookSendingService",
            "method": "sendWebhookForFirstTime"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "240b231587dbf162",
        "id": "cbdb7f9d44dc83c6",
        "kind": "CLIENT",
        "name": "get",
        "timestamp": 1643375072198728,
        "duration": 138007,
        "localEndpoint": {
            "serviceName": "some-gateway",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "http.method": "GET",
            "http.path": "/api/internal/path1/someid123"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "26640d33d4109f52",
        "id": "861359577e48ea8f",
        "kind": "CONSUMER",
        "name": "poll",
        "timestamp": 1643375075504819,
        "duration": 1,
        "localEndpoint": {
            "serviceName": "other-service",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "serviceName": "kafka"
        },
        "tags": {
            "kafka.topic": "com.company.label.created"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "861359577e48ea8f",
        "id": "aec32add6a009b17",
        "name": "on-message",
        "timestamp": 1643375075504974,
        "duration": 4488,
        "localEndpoint": {
            "serviceName": "other-service",
            "ipv4": "192.168.1.1"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "trace123idtrace123id",
        "id": "240b231587dbf162",
        "kind": "SERVER",
        "name": "post",
        "timestamp": 1643375072045085,
        "duration": 3462324,
        "localEndpoint": {
            "serviceName": "some-gateway",
            "ipv4": "192.168.1.1"
        },
        "remoteEndpoint": {
            "ipv4": "111.111.11.111"
        },
        "tags": {
            "http.method": "POST",
            "http.path": "/path2/v1/path3/path4"
        },
        "shared": true
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "01d29d9a99920587",
        "id": "d16d0ae633f4056f",
        "name": "on-message",
        "timestamp": 1643375075505071,
        "duration": 4661,
        "localEndpoint": {
            "serviceName": "webhook-service",
            "ipv4": "192.168.1.1"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "240b231587dbf162",
        "id": "67a3750b7e128b9c",
        "kind": "SERVER",
        "name": "get /api/internal/path1/{someid}",
        "timestamp": 1643375072047645,
        "duration": 149705,
        "localEndpoint": {
            "serviceName": "some-service",
            "ipv4": "192.168.109.180"
        },
        "remoteEndpoint": {
            "ipv4": "192.168.1.1",
            "port": 12345
        },
        "tags": {
            "http.method": "GET",
            "http.path": "/api/internal/path1/someid123",
            "mvc.controller.class": "InternalCallsController",
            "mvc.controller.method": "getSomethingById"
        },
        "shared": true
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "240b231587dbf162",
        "id": "67a3750b7e128b9c",
        "kind": "CLIENT",
        "name": "get",
        "timestamp": 1643375072045843,
        "duration": 151749,
        "localEndpoint": {
            "serviceName": "some-gateway",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "http.method": "GET",
            "http.path": "/api/internal/path1/someid123"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "e15b943cb34bea2a",
        "id": "18b4409a5719aead",
        "kind": "CLIENT",
        "name": "get",
        "timestamp": 1643375075509356,
        "duration": 238508,
        "localEndpoint": {
            "serviceName": "webhook-service",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "http.method": "GET",
            "http.path": "/api/internal/path1/someid123"
        }
    },
    {
        "traceId": "trace123idtrace123id",
        "parentId": "240b231587dbf162",
        "id": "6e8f6b3810ec68fd",
        "kind": "CLIENT",
        "name": "post",
        "timestamp": 1643375072337351,
        "duration": 3169287,
        "localEndpoint": {
            "serviceName": "some-gateway",
            "ipv4": "192.168.1.1"
        },
        "tags": {
            "http.method": "POST",
            "http.path": "/v1/path/pref-suffix"
        }
    }
]

Steps to Reproduce

  • Try to make a multiple nested calls and query the trace you'll find that some spans are missing according to the Json provided

Expected Behaviour

All spans included in the Json rendered in the UI

issue-screenshot
@mvahani
Copy link

mvahani commented May 3, 2022

We see the same thing. I'm pretty sure it's a bug. But I'm not so sure it will be fixed since the activity level in this project is really low :/

@acoLMO
Copy link

acoLMO commented Sep 1, 2022

Any news on this issue? I am still facing the same bug with the latest version.

Is there a fix/workaround for this?

@anujva
Copy link

anujva commented Nov 28, 2022

I have the same issue as well.

@seet61
Copy link

seet61 commented Dec 9, 2022

We have same Issue.

@Rathan-Naik
Copy link

Rathan-Naik commented Jan 1, 2023 •
edited

@seet61 @anujva
Can you post a sample JSON for which you are facing the issue?
Locally above JSON posted by @mostafaleantech lists all the spans.

@anujva
Copy link

anujva commented Jan 1, 2023

I was able to fix this. For the issue was the parent span was not being saved, which is why only the spans which had a parent were being rendered. Once I fixed the issue of the saving of the span, the UI started rendering them correctly.

@seet61
Copy link

seet61 commented Jan 9, 2023

@Rathan-Naik example
bb587ff076de11edb650005056b0c457 (2).zip

@jcchavezs
Copy link
Contributor

jcchavezs commented Jan 9, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jcchavezs @anujva @seet61 @Rathan-Naik @mvahani @acoLMO @mostafaleantech