[fix] Include all modified files in backup #206 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nemesifier Anything keeping this bugfix for the severe issue from getting merged? |
nemesifier
added this to In progress
in OpenWISP Priorities for next releases
via automation
|
@okraits sorry it slipped from my attention, I have added it to my todo list. The only small issue I noticed from the issue description is that it's not 100% clear to me how to replicate the issue for testing purposes, if you could provide a series of steps and sample configurations, it would make the review process faster. |
|
@nemesifier I updated the issue description to include a detailed example of how to reproduce the issue: #206 (comment) |
nemesifier
approved these changes
May 25, 2024
There was a problem hiding this comment.
I was able to replicate the bug and I confirm the fix works.
Thanks @okraits! 👍👍👍
OpenWISP Priorities for next releases
automation
moved this from In progress
to Reviewer approved
May 25, 2024
OpenWISP Priorities for next releases
automation
moved this from Reviewer approved
to Done
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206