Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyproject.toml so liccheck can pick the license #2074

Merged
merged 3 commits into from
May 24, 2024
Merged

Update pyproject.toml so liccheck can pick the license #2074

merged 3 commits into from
May 24, 2024

Conversation

samet-akcay
Copy link
Contributor

📝 Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@samet-akcay samet-akcay mentioned this pull request May 20, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (14ab566) to head (29adca0).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2074      +/-   ##
==========================================
- Coverage   81.32%   81.30%   -0.02%     
==========================================
  Files         229      229              
  Lines       10348    10348              
==========================================
- Hits         8415     8413       -2     
- Misses       1933     1935       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwinvaidya17 ashwinvaidya17 merged commit 64c123b into main May 24, 2024
8 of 9 checks passed
@ashwinvaidya17 ashwinvaidya17 deleted the samet-akcay-patch-1 branch May 24, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: liccheck not picking license name
2 participants
@samet-akcay @ashwinvaidya17