Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[invokers - interest] What to do with manual popovers on lose interest #1037

Open
brechtDR opened this issue Apr 12, 2024 · 4 comments
Open
Labels

Comments

@brechtDR
Copy link
Collaborator

#872 gave rise to the potential benefit of a loseinterest option again.

If we would have a manual popover that also gets triggered with interest. What happens when we lose focus? Does it close.

For the moment there isn't something to define this such as a loseinterestaction. Having a loseinterestaction might be too overloaded, but we should at least discuss the possibility, or how we would handle such use-cases.

@lukewarlow
Copy link
Collaborator

I wonder if rather than having a second attribute we can allow the attribute to be two space separated values? First for gain action second for lose action?

Idk if there's precedence for that sort of thing?

@lukewarlow
Copy link
Collaborator

Thinking on this some more I think a manual popover should behave just like a hint or auto wrt the interest behaviour. Just like invokers can open and close a manual popover, interest invokers should do the same.

The difference being that a manual popover doesn't close other popovers and doesn't have light dismiss.

@brechtDR
Copy link
Collaborator Author

brechtDR commented May 8, 2024

The difference being that a manual popover doesn't close other popovers and doesn't have light dismiss.

Interesting point of view. I'm just wondering if "losing focus" should be considered a "light dismiss" in this story? Because in that case, it does have some sort of light dismiss behavior when manual and interest combined with losing focus. If that makes sense.... I might be overthinking it.

@lukewarlow
Copy link
Collaborator

I get what you mean. "spec" wise light dismiss is explicitly click outside, so they're missing a close watcher AND light dismiss. But invokers are effectively the same as the imperative JS APIs, which always work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants