Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site title / logo breaks onto two lines on small (phone) screens #44

Open
smth opened this issue Jul 9, 2015 · 6 comments
Open

Site title / logo breaks onto two lines on small (phone) screens #44

smth opened this issue Jul 9, 2015 · 6 comments

Comments

@smth
Copy link
Contributor

smth commented Jul 9, 2015

No description provided.

@hoony-o-1
Copy link
Contributor

I think there are two ways to fix it.

  1. change line-height of .site-title.
  2. change height of .site-menu button.

which is better?

@danfowler
Copy link
Contributor

Thanks @hoony! Another option might be to reduce the font size of the site title at a certain breakpoint.

@hoony-o-1
Copy link
Contributor

that's nice, too. if then, it might be better to fix both of them, font-size and line-height. can I try?

@danfowler
Copy link
Contributor

Go for it! 😄

@hoony-o-1
Copy link
Contributor

@danfowler Could you let me know editor style guide of openspending or okfn? I just added a few lines but almost of indentation(or EOL?) of that file has changed.

@danfowler
Copy link
Contributor

@hoony OK. Here is the style guide: https://github.com/okfn/coding-standards

Can you try to prevent your editor from changing indentation and submit a pull request?

hoony-o-1 pushed a commit to hoony-o-1/community.openspending.org that referenced this issue Dec 4, 2015
fix title/logo breaks on small screan openspending#44
34055b1
hoony-o-1 pushed a commit to hoony-o-1/community.openspending.org that referenced this issue Dec 4, 2015
change site-title from broken line to one line on small screen opensp…
b7c97ec 
…ending#44
danfowler added a commit that referenced this issue Dec 21, 2015
@danfowler
Merge pull request #68 from hoony/fix-responsive-title
ea246b6 
fix title/logo breaks on small screan #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danfowler @hoony-o-1 @smth