-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43764: Revendor to a patched k/k with our prefer-local-DNS hack #638
OCPBUGS-43764: Revendor to a patched k/k with our prefer-local-DNS hack #638
Conversation
(Also updates from v1.30.3 to v1.30.5.)
@danwinship: This pull request references Jira Issue OCPBUGS-43764, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@danwinship: This pull request references Jira Issue OCPBUGS-43764, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/override ci/prow/unit openshift/sdn CI is broken on master |
@danwinship: Overrode contexts on behalf of danwinship: ci/prow/unit, ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@danwinship: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
18a57d7
into
openshift:master
@danwinship: Jira Issue OCPBUGS-43764: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-43764 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.17 |
@danwinship: new pull request created: #640 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
Apparently IBM was relying on this behavior in the standalone kube-proxy image.
(This also updates from k8s v1.30.3 to v1.30.5, which pulls in some irrelevant changes, and probably I should have just stuck with 1.30.3 to keep it simple but whatever. Anyway, the relevant change is in
vendor/k8s.io/kubernetes/pkg/proxy/iptables/proxier.go
.)The
replace
stuff ingo.mod
is just taken from the 4.16 branch. I had simplified things when rebasing to 1.30 for 4.17 because we weren't going to be keeping local patches any more, but now we are again, so...