Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43561: add zsh completion #9116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-43561: add zsh completion #9116

wants to merge 1 commit into from

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Oct 18, 2024 •
edited
Loading

openshift-install-completion-zsh.txt

Fixes #9115

Seems to work

~/git/installer zshcompletion*
❯ openshift-install create i
completions
ignition-configs  -- Generates the Ignition Config asset
install-config    -- Generates the Install Config asset

Signed-off-by: Tiger Kaovilai [email protected]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign r4f4 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kaovilai added a commit to kaovilai/installer that referenced this pull request Oct 18, 2024
@kaovilai
add completion generated from openshift#9116
65ed053 
Signed-off-by: Tiger Kaovilai <[email protected]>
kaovilai added a commit to kaovilai/dotfiles that referenced this pull request Oct 18, 2024
@kaovilai
Add completion generated from openshift/installer#9116
379d6ca 
Signed-off-by: Tiger Kaovilai <[email protected]>
@kaovilai kaovilai marked this pull request as ready for review October 18, 2024 15:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@kaovilai kaovilai changed the title add zsh completion OCPBUGS-43561: add zsh completion Oct 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@kaovilai: This pull request references Jira Issue OCPBUGS-43561, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

openshift-install-completion-zsh.txt

Fixes #9115

Seems to work

~/git/installer zshcompletion*
❯ openshift-install create i
completions
ignition-configs  -- Generates the Ignition Config asset
install-config    -- Generates the Install Config asset

Signed-off-by: Tiger Kaovilai [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kaovilai
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 18, 2024
@openshift-ci-robot
Copy link
Contributor

@kaovilai: This pull request references Jira Issue OCPBUGS-43561, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei October 18, 2024 15:49
@kaovilai
add zsh completion
ddd6ca1 
Signed-off-by: Tiger Kaovilai <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@bfournie bfournie Awaiting requested review from bfournie

@gpei gpei Awaiting requested review from gpei

Assignees
No one assigned
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OCPBUGS-43561: openshift-install completion zsh
2 participants
@kaovilai @openshift-ci-robot