Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional linking capability from Read to Lexicon. #104

Open
marcstober opened this issue Apr 21, 2024 · 0 comments
Open

Additional linking capability from Read to Lexicon. #104

marcstober opened this issue Apr 21, 2024 · 0 comments

Comments

@marcstober
Copy link
Contributor

Thank you for accepting my recent pull request #103 to add linking to the Read app.

I've taken this a step further and added linking capability from the Read app to the Lexicon. You can see this in action at https://marcstober.github.io/morphhb/read/index.html. Hover on a word, and now you can click on the lemma (e.g., Strong's number) in the popup, and be taken to the related entry in the Lexicon.

I haven't submitted a pull request for a few reasons, the biggest one of which is that actually deploying it would require some coordinated changes between the Read and Lexicon apps (currently there's a hard-coded URL to my fork). It's also a little more involved of a change that is really just a proof-of-concept for some other things I am working on; I'm not sure if what I have is exactly what should go on openscriptures.org. In any case, the code is in my Github account (with a CC-BY license), so I wanted to let you know in case you wanted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant