-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry support #1345
Comments
I think it is a great idea but I would wait until events in Open Telemetry are stable. Should be this year. |
Just curious, what do you mean by stable? What issues would hinder this and in what way? @SebastianStehle |
Like most things, the reason is actually simpler: because you're the first one asking for it 😄 |
Im learning as much as i can on those APIs so im not any expert by any means but i just mainly wanted to see whether or not it would be a waste of time to contribute something or atleast a naive prototype on this topic 🙂 But it sounds like its an not that farfetched idea then 👍 |
Open Telemetry has several components:
Only tracing is ready, but when you go over the code it makes sense to introduce a few events as well. Therefore I would implement it in one step. |
Thank you for the clarification. Sounds like a reasonsble approach 👍 |
Any updates on the possibility of implementing opentelemetry traces and metrics? |
Hi, any updates on implementing opentelemetry ? |
No immediate plans (since no one offered to fund that). That said, there's a demand, so maybe in the future. |
It's already there, to a degree, .net8 introduces the aspnet System.Diagnostics.Metrics, so my company is currently using the opentelemetry.net sdk to export and observe our openiddict endpoint activity. If openiddict were to do anything natively, it would be to add custom meters/metrics to measure certain things that occur within the API itself. What's important to see? The aspnet http requests themselves are already covered. e.g.
|
Is your feature request related to a problem?
Not really a problem but a difficulty in primarly understanding performance behaviour but also lack of tracing ability of middleware.
Describe the solution you'd like
Hi, have there been any thoughts on adding some kind of telemetry support? If so are there any technical reasons for not wanting to add such support from your point of view? Do you see a future need for such a thing? If one would at some point try to add such a thing would it be taken into considerstion?
Additional context
The text was updated successfully, but these errors were encountered: