Custom bug parser ignored in roundup.py

[ghost]

Comment by catherinedevlin:

BugImportSpider in bugimporters/main.py is written to read a
special_bug_parser_name from the .yaml and store it as bug_importer's
bug_parser. That part is working fine.

However, in RoundupBugImporter.handle_bug_html_response in
bugimporters/roundup.py, the custom bug parser (stored in .bug_parser) is simply
ignored; instead RoundupBugParser is hard-coded as the bug parser.

Attaching a patch which, if applied and run with
python bugimporters/main.py -i examples/pyorg-roundup.yaml -o json
will write into the log a message showing that the default bug parser is being
used despite the setting in pyorg-roundup.yaml.

I'll provide a suggested patch to fix it shortly.

---

Comment by catherinedevlin:

Fixes the bug by calling self.bug_parser instead of hardcoded RoundupBugParser.

---

Comment by paulproteus:

zomg, amazing. Thank you!

If you can turn this into a GitHub pull request, that'd be convenient.
Either way, I hope to review + merge later today.

---

Comment by catherinedevlin:

Ah, of course. Pull request submitted:
#49

---

Comment by paulproteus:

This is fixed. Thanks to all!

---

Comment by ehashman:

Need to add a test for this patch after merging the PR. Picking this up.

---

File at http://roundup-archive.openhatch.org/bugs/file669/fix962.patch by catherinedevlin

Status: in-progress
Nosy List: catherinedevlin, ehashman, paulproteus
Priority: bug
Imported from roundup ID: 962 (view archived page)
Last modified: 2014-05-04.21:43:30