Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-lottie is abandoned and uses deprecated lifecycle methods #1083

Closed
zwliew opened this issue Mar 24, 2021 · 1 comment
Closed

react-lottie is abandoned and uses deprecated lifecycle methods #1083

zwliew opened this issue Mar 24, 2021 · 1 comment
Assignees
Labels
chore Chore

Comments

@zwliew
Copy link
Contributor

zwliew commented Mar 24, 2021

Describe the bug
react-lottie is the library we use to render the landing page animation. It appears to be abandoned and uses deprecated lifecycle methods (componentWillUpdate).

This is an issue because the lifecycle method will be removed in future React versions.

To Reproduce
Steps to reproduce the behavior:

  1. Run the frontend in development mode locally
  2. There should be a console warning (see: Move data fetching code or side effects to componentDidUpdate. chenqingspring/react-lottie#119 (comment))

Expected behavior
There should be no console warning.

Possible Solution
We can migrate to the lottie-react library. It fixes the issue and is expected to have React 17 support soon. Furthermore, the library is written in TypeScript and seems to have better code quality compared to other alternatives like react-lottie-player.

@zwliew
Copy link
Contributor Author

zwliew commented Mar 30, 2021

Fix merged

@zwliew zwliew closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore
Projects
None yet
Development

No branches or pull requests

1 participant