Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple PackageInstaller with Android 9.0 #287

Open
ujwal-setlur opened this issue Feb 8, 2021 · 4 comments
Open

Multiple PackageInstaller with Android 9.0 #287

ujwal-setlur opened this issue Feb 8, 2021 · 4 comments

Comments

@ujwal-setlur
Copy link

I am using the pico variant because I just need Play services, but it seems the GooglePackageInstaller that is installed conflicts with the one that comes with Android 9.0. The error in logcat is:

There must be only one installer

I then tried excluding the GoogleInstaller with:

GAPPS_EXCLUDED_PACKAGES := GooglePackageInstaller

That did not work either. Then I edited opengapps-packages.mk and commented out the following line:

# ifneq ($(filter 23,$(call get-allowed-api-levels)),)
# GAPPS_PRODUCT_PACKAGES += \
#     GoogleTTS \
#     GooglePackageInstaller
# TVGAPPS_PRODUCT_PACKAGES += \
#     GooglePackageInstaller
# endif

This ended up fixing the issue. Is there a more correct way to avoid this conflict?

@MarijnS95
Copy link
Contributor

GooglePackageInstaller is configured to supersede PackageInstaller. Android 9 can't yet figure out what files need to end up in the image and likely uses a PackageInstaller from an earlier build remaining in out/target/product/<your-device>/....

Running m installclean before rebuilding should resolve that - though it is curious that omitting GooglePackageInstaller solves the issue, as it should also inadvertently remain in the build.

@ujwal-setlur
Copy link
Author

I'll try that but I started from a fresh repo, I believe...

@MarijnS95
Copy link
Contributor

Check and paste the exact error: this includes the paths/package names to both PackageInstallers.

@ujwal-setlur
Copy link
Author

@MarijnS95 I can't seem to reproduce this anymore. Maybe I hadn't cleaned my tree after all. Now it works with me not having to disable or exclude GooglePackageInstaller at all. Just specifying GAPPS_VARIANT := pico works now.

Sorry for the noise. I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants