Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly Build Release checklist #8192

Open
8 of 12 tasks
ofTheo opened this issue Nov 15, 2024 · 15 comments
Open
8 of 12 tasks

Nightly Build Release checklist #8192

ofTheo opened this issue Nov 15, 2024 · 15 comments

Comments

@dimitre
Copy link
Member

dimitre commented Nov 15, 2024

it seems RPI libs (and others) download is not working :
bzip2: (stdin) is not a bzip2 file.
https://github.com/openframeworks/openFrameworks/actions/runs/11860266785/job/33055126869

@ofTheo
Copy link
Member Author

ofTheo commented Nov 19, 2024

@danoli3 @roymacdonald @dimitre @artificiel @oxillo

Let's try and get these nightly builds actually working! :-)

Would be great if you have a moment to download the nightly builds from:
https://github.com/openframeworks/openFrameworks/releases/tag/nightly

And try both allAddonsExample and use the PG to generate a project and see if things build successfully.

Right now macOS is broken ( see #8170 ) but I could imagine VS / msys and others might have issues too.

@dimitre
Copy link
Member

dimitre commented Nov 19, 2024

Actions are not working as they should.
Libraries are pointing to 404 in half of the platforms.

@artificiel
Copy link
Contributor

artificiel commented Nov 19, 2024

of_v20241109_ios_release: tested with macOS 14.5 on M1 with a 16.0.1 device. successfully compiled-run 3 examples (fontShapesExample, soundPlayerExample, vboExample). (not sure about allAddonsExample on this...?)

A handful of compiler warnings; nothing outrageous.
Simulators don't work, but "Designed for iPad" does.

PG 0.83.0 pointed to the correct OF tree but came up configured with the "OSX" platform, which threw me off a moment until i noticed i was compiling a mac project. once re-seated to "iOS (Xcode)" things worked, with a simple OSC test to the broadcast LAN.

@ofTheo
Copy link
Member Author

ofTheo commented Nov 19, 2024

@artificiel - that's some welcome news! I know the iOS stuff was a big focus for all the apothecary changes.
Great to hear its all working.

@dimitre
Copy link
Member

dimitre commented Nov 19, 2024

now pg is adding correctly xcframeworks. allAddonsExample still fails on opencv / carotene
it works if you substitute the .a file with the one from "ALTpothecary"
https://github.com/dimitre/ofChalet/releases

@dimitre
Copy link
Member

dimitre commented Nov 19, 2024

Investigating more of the scripts to build of nightly, it seems there are a lot of scripts being called with "-b" parameter which is to enable variable BLEEDING_EDGE in scripts/dev/download_libs.sh
which in turn decides if $VER variable is "latest" or "master"

Looking at apothecary libs, we have the relation between the releases and $ver variable
latest = latest
bleeding = bleeding
nightly = master

that is strange.
but to make it work as it is we should set VER = $REPO and if repo == nightly set it to master.

@artificiel
Copy link
Contributor

@dimitre haha well indeed this should be disentangled.

if we are to advertise git repo for common consumption (in coherence to "use nightlies" as discussed in another thread) it is important that it's easy to understand, as working in git means using download_libs periodically.

current name use download_libs suggested branch rename CI note
master "stable git" default stable nightlies default branch
bleeding active devs -flag required develop (or active) ¿ just tests ?
latest latest bin n/a n/a point releases

could the download_libs script be adjusted so it does the right thing by default? It can detect which branch the user is switched to. in any case the switch would follow the branch name so it's 1:1

(I'm not sure where is the best place to have this conversation it seems like an all-encompassing topic)

@dimitre
Copy link
Member

dimitre commented Nov 19, 2024

I think everything is more complex than it should be so in my opinion we can use only repo and set $VER accordingly.
with this plus some changes in OpenCV formula we can get nightly building to test. we can copy settings from "Altpothecary" to make it work.
Questions: is VideoIO needed in opencvPeopleDetector?
should we remove "videoio" include and settings from apothecary?
should we guard with #if defined(HAVE_OPENCV_VIDEOIO) ?

@ofTheo
Copy link
Member Author

ofTheo commented Nov 19, 2024

@danoli3 - would love some input to the above - especially @artificiel 's grid.
Would be good to know what the plan was and what we should be pointing people to.

@ofTheo
Copy link
Member Author

ofTheo commented Nov 19, 2024

@dimitre

Questions: is VideoIO needed in opencvPeopleDetector?
should we remove "videoio" include and settings from apothecary?

I don't believe videoIO is needed for that example. I am guessing there are a fair number of things we can turn off that might help compilation.

We could def add those OpenCV examples to the CI testing though, as it's easy to build OpenCV without the libs needed for the newer examples we added.

@roymacdonald
Copy link
Contributor

roymacdonald commented Nov 19, 2024

As for the macos opencv issue, the problem is twofold. First, the library is compiled somehow that it is missing stuff. The one in here works while the one in latest does not.

Second, it is the project generator.
This commit broke it

That is the problem but I am not fixing it.

I am done with all this, I spent 2 weeks working full time in order to get PG working again and then in an attempt to fix something that was not broken it actually gets broken and apparently not tested properly. I am tired of this way of developing and I am out.
I've been contributing to this community for at least 14 years but now it is time to move on, so this is actually a really tough decision to make.
I will still keep on using OF but no longer count with me for its core development.

I wish you the best and I hope that OF manages to keep afloat.

@ofTheo
Copy link
Member Author

ofTheo commented Nov 26, 2024

Getting pretty close here, the last two issues in this list are the PG issues regarding adding subfolders of src/ and local addons.

I think in addition a couple of the actions/runners are failing.
I can look into those.

@dimitre
Copy link
Member

dimitre commented Nov 26, 2024

hey @ofTheo can you explain better the PG issues? which platform?
I've just tested with subfolders of src and additional sources and it is working OK here

Screenshot 2024-11-26 at 17 29 35

@dimitre dimitre pinned this issue Nov 26, 2024
@dimitre
Copy link
Member

dimitre commented Nov 26, 2024

Now I've read about this in VS. I'll take a look soon.
I've updated with some other issues happening on nightly/latest, if others can jump and help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants