You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The from_pandas method of the openff.evaluator.datasets.PhysicalPropertyDataSet object returns an instance of the PhysicalPropertyDataSet object, but the from_json method returns a dictionary. These methods should both return the same object to avoid confusion.
After doing a bit of digging, the issue is that the from_pandas method is owned by PhysicalPropertyDataSet, whereas the from_json method is inherited from the TypeBasedModel class, leading to different behavior for two methods you'd expect to do the same thing.
The
from_pandas
method of theopenff.evaluator.datasets.PhysicalPropertyDataSet
object returns an instance of thePhysicalPropertyDataSet
object, but thefrom_json
method returns a dictionary. These methods should both return the same object to avoid confusion.Example code
Output
Conda env
Example script and files are also attached.
dataset_issue.zip
The text was updated successfully, but these errors were encountered: