Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #159 Added support for binary data in request and response #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erlendv
Copy link

@erlendv erlendv commented Jul 19, 2019

Adds support for binary data in requests and responses. #159

Description

Added IResponse.setBody(byte[]), IResponse.getBodyData() and implemented them in Response
Added IRequest.getInputStream() and implemented it in Request
Changed entrypoint App to use these new methods.

Motivation and Context

#159

  • I have raised an issue to propose this change (required)

Which issue(s) this PR fixes

Fixes #159

How Has This Been Tested?

Added tests to RequestTest and ResponseTest. Verified that my original problem described in #159 is fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Jul 19, 2019

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for this PR, it looks good far, but I have a few suggestions and sign-off is needed too.

Alex

@alexellis
Copy link
Member

Please could you squash both commits into one? You should be able to get help from Google as this is a common practice. Failing that route, the community is active on Slack and always ready to help contributors.

Thank you for your PR

@alexellis
Copy link
Member

/msg: slack

@derek
Copy link

derek bot commented Aug 1, 2019

--
Join Slack to connect with the community
https://docs.openfaas.com/community

Copy link

@kameshchauhan kameshchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments for code quality.

@alexellis
Copy link
Member

@erlendv please take a look at the comments and squash down your commits into one, when you are ready. This is a good change so I would like to get it in soon.

@erlendv
Copy link
Author

erlendv commented Aug 2, 2019

Sorry for late feedback @alexellis and @kameshchauhan. Im on vacation so a bit online/offline. I will fix shortly!

@alexellis
Copy link
Member

Thank you @erlendv - please could you sign-off your commits? If you need help, please ask on Slack.

@alexellis
Copy link
Member

Perhaps we can squash the 5 commits with git reset HEAD~5 and then add / commit them again?

@erlendv
Copy link
Author

erlendv commented Aug 11, 2019

I think I (finally) managed to squash the commits and have the one signed off @alexellis. All requested changes have been implemented.

@erlendv
Copy link
Author

erlendv commented Sep 26, 2019

@alexellis I think til PR is all good now? All requested changes have been done, all commits squashed and the one commit is signed off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for binary response and binary request body in java8 template
3 participants