Fix vendoring for golang-http

[alexellis]

Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]

Description

Fix vendoring for golang-http by reverting to method prior to workspaces

How Has This Been Tested?

Tested with a private Go module which was vendored, setting GO111MODULE: off in build_args in stack.yml

I also created a nested package called pkg and referenced it as "handler/function/pkg" from handler.go which worked as expected.

Closes: #78

How are existing users impacted? What migration steps/scripts do we need?

Imports remained the same, but we will need to check docs and blog posts

https://www.openfaas.com/blog/golang-deep-dive/

https://github.com/openfaas/golang-http-template#20-golang-http

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• read the CONTRIBUTION guide
• signed-off my commits with git commit -s
• added unit tests

For the privately vendor code:

version: 1.0
provider:
  name: openfaas
  gateway: http://127.0.0.1:8080
functions:
  jwtme:
    lang: golang-http
    handler: ./jwtme
    image: alexellis2/jwtme:latest
    build_args:
      GO111MODULE: off
      GOFLAGS: -mod=vendor

For using Go modules w/o any vendoring:

package function

import (
        "fmt"
        "net/http"

        handler "github.com/openfaas/templates-sdk/go-http"
        "github.com/sirupsen/logrus"
)

// Handle a function invocation
func Handle(req handler.Request) (handler.Response, error) {
        var err error

        logrus.Info("Function started")

        message := fmt.Sprintf("Body: %s", string(req.Body))

        return handler.Response{
                Body:       []byte(message),
                StatusCode: http.StatusOK,
        }, err
}

The stack.yml file was unchanged.

[alexellis]

@LucasRoesler @mrwormhole

[mrwormhole]

https://www.diffchecker.com/lhoTkAHq shall we keep remove_workspaces for ./function/go.work? does the arm build still break?

[mrwormhole]

found it, gotta do the shell script right before test -z

[mrwormhole]

for reference, see here old format file; https://github.com/openfaas/golang-http-template/pull/81/files#diff-cab65cb33a949d149a9235a974191f15e1b6c43367b5301c9fd77cc59c396897; this last tested one as working

[alexellis]

@mrwormhole sorry, what question are you asking?

[mrwormhole]

@alexellis is ARM build running successfully? before the changes, we did run modules-cleanup.sh right before test -z command

also second thing, dockerignore file should point to function/vendor/github.com/openfaas-incubator/go-function-sdk instead of function/vendor/github.com/openfaas/go-function-sdk

[alexellis]

Why? There is no repo in openfaas-incubator? That's deprecated.

[alexellis]

This is now available for pinning:

https://github.com/openfaas/golang-http-template/releases/tag/0.8.0

cc @willfore - this change makes vendoring private Go modules possible again with golang-http.