Make PR template more pertinent to docs changes #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Gee <[email protected]>
|
Nice, I like it 💃 |
alexellis
reviewed
Oct 8, 2019
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| - [ ] My change requires a change to the documentation. | ||
| - [ ] I have updated the documentation accordingly. | ||
| - [ ] I have tested any new instructions | ||
| - [ ] I am the author |
There was a problem hiding this comment.
I think this declaration makes sense, but some people (international speakers, perhaps) may assume this means that they created the PR. Can we be more specific, but remain concise?
Do we need both?
What about:
- [ ] I have included copyrighted materials from third parties.
- [ ] I have permission to use copyrighted materials from third parties.
There was a problem hiding this comment.
To some extent this is also covered under the DCO
Signed-off-by: Richard Gee <[email protected]>
|
I like this a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Richard Gee [email protected]
Description
Motivation and Context
How Has This Been Tested?
Its an issue template
Types of changes
Checklist:
git commit -s