Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Certificate step from SSL page? #160

Open
alexellis opened this issue Jul 1, 2019 · 2 comments
Open

Remove Certificate step from SSL page? #160

alexellis opened this issue Jul 1, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed size/s

Comments

@alexellis
Copy link
Member

Proposed change

We may be able to remove the additional create Certificate step from SSL page.. https://docs.openfaas.com/reference/ssl/kubernetes-with-cert-manager/

Context

It seems like cert-manager's Ingress shim (available since 0.2.2) automatically creates certificates if an Ingress object is decorated appropriately. This is simpler than us instructing the user to create a separate Certificate object.

Found by: @ajaegle

openfaas/ingress-operator#6

Your Environment

We should test that the certificate is created automatically before removing the explicit step.

@LucasRoesler
Copy link
Member

I think we should remove it, but make sure to add a callout in the docs that this only "works for cert-manager 0.2.2+ when ingress-shim is installed, the default configuration." Or some other similar wording.

@alexellis
Copy link
Member Author

Whilst I appreciate the caution, we currently tell people to use cert-manager is at 0.7.0, so I don't think the notice is needed (for that reason).

@alexellis alexellis reopened this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed size/s
Projects
None yet
Development

No branches or pull requests

2 participants