Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exposing the gateway on a different port #136

Open
LucasRoesler opened this issue Mar 11, 2019 · 4 comments
Open

Document exposing the gateway on a different port #136

LucasRoesler opened this issue Mar 11, 2019 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@LucasRoesler
Copy link
Member

Proposed change

The docs should show developers how to change the public port of the gateway. In both swarm and k8s this is not very complicated. We should warn users about exposing it publically, but for developers testing OpenFaaS they might have port conflicts on their local systems.

The docs should identify use cases and which files would need to be modified.

Context

Several users have asked about this in Slack. Documenting this will simplify the developer experience.

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • Link to your project or a code example to reproduce issue:

  • Please also follow the troubleshooting guide and paste in any other diagnostic information you have:

@alexellis
Copy link
Member

Want to /add label: help wanted or assign?

@LucasRoesler
Copy link
Member Author

/add label: help wanted

@derek derek bot added the help wanted Extra attention is needed label Mar 11, 2019
@alexellis alexellis added the good first issue Good for newcomers label Mar 11, 2019
@alexellis
Copy link
Member

In both swarm and k8s this is not very complicated.

I don't agree, this is very complicated for Kubernetes and I've seen had anyone ask for that target platform.

I'd see this as only covering Swarm and docker-compose.yml.

@alexellis
Copy link
Member

@LucasRoesler can you go ahead and pick this up between now and KubeCon, but only for Swarm?

If we start to see users how to change their ingress controllers, then I would be happy to cover that at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants