Handling sentences without place names

[ahalterman]

What's the expected behavior when Profile does not find a place name (perhaps because there is none)? Right now it gives an IndexError, which is really easy to catch and replace with maybe "", but this is making me wonder if this is the version of the code that was run on XCEDE, since this issue surely would have come up. Do you suggest I just put an exception around it and return ""? And is there another version of the code somewhere?

In [23]: TextTest = "The president gave a speech from nowhere."

In [24]: print( Profile.main(lang, NER, TextTest, word2vec_Dictionary, loaded_model) )
loading NER model...
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-24-3a6e4b6f68c5> in <module>()
----> 1 print( Profile.main(lang, NER, TextTest, word2vec_Dictionary, loaded_model) )

/home/ahalt/Focus_Locality_Extraction/Focus_Locality/Sentence_Embedding_Approach/Testing/Profile.pyc in main(lang, NER, TextTest, word2vec_Dictionary, loaded_model)
     38         sorted_loc = sorted(locDic, key=locDic.__getitem__, reverse=True)
     39
---> 40     return sorted_loc[0]
     41
     42

IndexError: list index out of range

[Maryam-Imani]

I tested it with some text. It seems my test cases were not complete. I will add the exception to it. Thanks

What's the expected behavior when Profile does not find a place name (perhaps because there is none)? Right now it gives an IndexError, which is really easy to catch and replace with maybe "", but this is making me wonder if this is the version of the code that was run on XCEDE, since this issue surely would have come up. Do you suggest I just put an exception around it and return ""? And is there another version of the code somewhere?

In [23]: TextTest = "The president gave a speech from nowhere."

In [24]: print( Profile.main(lang, NER, TextTest, word2vec_Dictionary, loaded_model) )
loading NER model...
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-24-3a6e4b6f68c5> in <module>()
----> 1 print( Profile.main(lang, NER, TextTest, word2vec_Dictionary, loaded_model) )

/home/ahalt/Focus_Locality_Extraction/Focus_Locality/Sentence_Embedding_Approach/Testing/Profile.pyc in main(lang, NER, TextTest, word2vec_Dictionary, loaded_model)
     38         sorted_loc = sorted(locDic, key=locDic.__getitem__, reverse=True)
     39
---> 40     return sorted_loc[0]
     41
     42

IndexError: list index out of range

I tested it with some text. It seems my test cases were not complete. I will add the exception to it. Thanks