-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit the .ebnf output into the repo #540
Comments
Thanks for using with the openCypher artifacts. It is a general practice of the openCypher repo to not include built artifacts. Exceptions to that rules require very good reason. The reason you are providing is not convincing. I do not see why you have to check the diff of a rebuilt EBNF. Why not just using the regenerate EBNF? Conversely, if the actual EBNF diff is an essential input to your usage of the grammar and if we would include the EBNF into the repo, then you would still will have the obtain the diff of the EBNF. So, I can not see any benefit regarding the diff. If it is the regeneration of the EBNF, i.e. running the build, that bothers you, I am afraid I can not help you either. The repo contains the source code and not the generated artifacts. The generated artifacts are released in milestones. This gives you two options to chose from:
|
Please include the generated opencypher EBNF file in the repo
Otherwise, for those relying on the .ebnf file, for every update in the grammar those people would have to regenerate the file and check the diff.
The text was updated successfully, but these errors were encountered: