Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky test: TestCheckpoint(actuated-arm64-6cpu-8gb, 1.21.x) #4274

Closed
lifubang opened this issue May 7, 2024 · 2 comments · Fixed by #4276
Closed

flaky test: TestCheckpoint(actuated-arm64-6cpu-8gb, 1.21.x) #4274

lifubang opened this issue May 7, 2024 · 2 comments · Fixed by #4276

Comments

@lifubang
Copy link
Member

lifubang commented May 7, 2024

Sometimes fail:

=== RUN   TestCheckpoint
    checkpoint_test.go:115: === /tmp/TestCheckpoint1387080808/003/criu-parent/dump.log ===
    checkpoint_test.go:115: open /tmp/TestCheckpoint1387080808/003/criu-parent/dump.log: no such file or directory
    checkpoint_test.go:119: CRIU feature check failed
--- FAIL: TestCheckpoint (0.24s)

Sometimes success to skip:

=== RUN   TestCheckpoint
    checkpoint_test.go:115: === /tmp/TestCheckpoint194762558/003/criu-parent/dump.log ===
    checkpoint_test.go:115: open /tmp/TestCheckpoint194762558/003/criu-parent/dump.log: no such file or directory
    checkpoint_test.go:117: criu is missing features: [MemTrack]
--- SKIP: TestCheckpoint (0.51s)
@kolyshkin
Copy link
Contributor

I am working on that. The issue is, criu feature check is not doing what it should.

@kolyshkin
Copy link
Contributor

Interesting; I've never seen it being able to skip! I guess it was skipping when using a runner with an older kernel.

I found two reasons for the test to fail.

  1. actuated-arm64 currently runs a kernel with CONFIG_NF_TABLES_INET not set, which uncovers a bug in criu (see criu: fix a fatal failure if nft doesn't work checkpoint-restore/criu#2403).

  2. It seems that the feature check test is not working like it should. I've added a patch to not test pre-dump if memory tracking is not available (one of commits in PR fix checkpoint/restore tests on actuated-arm64 #4276).

These two PRs address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants