-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerd/crio passes invalid config.json #4133
Comments
@cyphar AFAIK runc behavior is at fault here too. runc before that commit (i.e. all releases) I think the only way to join a userns path was if you ALSO specified the mappings. So tools are using that way and now we want to change it, which creates issues, of course. |
Yeah, you're right. I forgot that I fixed this in that PR 😅. I've suggested some of the text in opencontainers/runtime-spec#1237 be reworded and a reference to this incorrect behaviour be added to help clarify things for folks who run into this in the future. |
Originally posted by @rata in #3985 (review)
Due to the invalid
config.json
s being passed by containerd and crio (possibly among others), we have to downgrade the relevant error added in 09822c3 to a warning if the mappings match the passed path.The text was updated successfully, but these errors were encountered: