Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seccomp flag handling is broken #3582

Closed
kolyshkin opened this issue Aug 31, 2022 · 1 comment · Fixed by #3580
Closed

seccomp flag handling is broken #3582

kolyshkin opened this issue Aug 31, 2022 · 1 comment · Fixed by #3580

Comments

@kolyshkin
Copy link
Contributor

Looking at the runc seccomp code, it seems that our flag handling (added by #3390) is broken.

This happens because since #2750 runc no longer uses libseccomp-golang's filter.Load(), but rather implements its own loader.

This means, that whatever flags we set using libseccomp-golang's filter.SetXXX() are not being used.

Instead, patchebpf.filterFlags is used to query flags from the filter and set them. Alas, it only supports a subset of currently supported flags.

@rata
Copy link
Member

rata commented Sep 6, 2022

cc @alban

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants