Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of json for policy in authz without a protobuf alternative is obtuse #136

Open
haussli opened this issue Dec 1, 2023 · 2 comments
Open

Comments

@haussli
Copy link
Contributor

haussli commented Dec 1, 2023

Use of json for policy in authz without a protobuf alternative is obtuse. Why use json at all? And, why not offer a native protobuf alternative?

Use of JSON seems inconsistent and unnecessary. If the server wishes to use JSON internally, that is its prerogative, but should not be part of the API, or the user should have the option of using either.

My suggestion is that at the very least, a native protobuf version should be supported. This is not my call though; @tomek-US probably needs to decide this.

This is a split of issues/99; #99 (comment)

@morrowc
Copy link
Contributor

morrowc commented Dec 1, 2023

Is it the case that we want to support 2 possible policy languages (json/proto) or to support 1, but have 'many' input options (with a proto -> json conversion cleanly supported in tooling)?

(at some point I thought: "proto3 text format is json" - though I admit to always looking at json with 'skepticism'...)

@haussli
Copy link
Contributor Author

haussli commented Dec 1, 2023

IMHO, support 1 format - protobuf. json inside protobuf seems unnecessarily kinky. But, I do not think this is my decision and there is clearly some precedence here with the origin of authz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants