Unexpected end of JSON input

[samuelpucat]

Description

I have a similar problem to issue #1933, I'm calling non-returning API defined like this.

generated schema.d.ts:

export interface operations {
    ...
    deleteLoadBalancer: {
        parameters: { ... };
        requestBody?: never;
        responses: {
            /** @description OK */
            200: {
                headers: {
                    [name: string]: unknown;
                };
                content?: never;
            };
        };
    };
    ...
}

calling api:

const { data } = await client.DELETE('/load-balancers/{name}', {
    params: {
        header: { correlationId: generateCorrelationId() },
        path: { name: loadBalancerName },
        query: { projectId },
    },
    // parseAs: 'text',
});

throws error:

SyntaxError: Unexpected end of JSON input
    at u (index.js:164:44)

which is in this part of library:

// parse response (falling back to .text() when necessary)
if (response.ok) {
  // if "stream", skip parsing entirely
  if (parseAs === "stream") {
    return { data: response.body, response };
  }
  return { data: await response[parseAs](), response };      // line 164
}

Calling the API with parseAs: 'text', solves the error but I don't know whether it is the correct solution.
I feel like this should have been caught by this part of code:

// handle empty content
if (response.status === 204 || response.headers.get("Content-Length") === "0") {
  return response.ok ? { data: undefined, response } : { error: undefined, response };
}

but this API doesn't have Content-Length response header nor have 204 status

Question

Like I said, I would like to ask for advice, what would be the best approach:

• call the API with parseAs: 'text' flag
• change the API to return 204 status and Content-Length: 0 response header
• extend the openapi-fetch library to fail gracefully in case the response isn't possible to parse as JSON