Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAIChatCompletionFn should __init__ should accept **kwargs #1493

Open
ezraporter opened this issue Mar 15, 2024 · 0 comments · May be fixed by #1494
Open

OpenAIChatCompletionFn should __init__ should accept **kwargs #1493

ezraporter opened this issue Mar 15, 2024 · 0 comments · May be fixed by #1494
Labels
bug Something isn't working

Comments

@ezraporter
Copy link

Describe the bug

Currently the __init__ method for OpenAICompletionFn has **kwargs but OpenAIChatCompletionFn does not. This creates problems if I have both:

  • a custom completion function that takes arguments I would like to populate with --completion_args
  • a modelgraded eval that I plan to grade with an OpenAI model

In these cases I would like to do:

oaieval my_completion_fn,gpt-4-turbo-preview my_eval --completion_args my_param=my_value

But I get:

TypeError: OpenAIChatCompletionFn.__init__() got an unexpected keyword argument 'my_param'

To Reproduce

Run oaieval gpt-3.5-turbo test-match --completion_args ignore_me=1

Code snippets

No response

OS

macOS

Python version

Python v3.11.7

Library version

openai-evals 2.0.0.post1

@ezraporter ezraporter added the bug Something isn't working label Mar 15, 2024
@ezraporter ezraporter linked a pull request Mar 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant