Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_memory always got True in chroma_datastore #401

Open
zanghu opened this issue Dec 26, 2023 · 0 comments
Open

in_memory always got True in chroma_datastore #401

zanghu opened this issue Dec 26, 2023 · 0 comments

Comments

@zanghu
Copy link

zanghu commented Dec 26, 2023

Thanks for your time!

In chroma_datastore.py, the os.getenv function returns the value of the CHROMA_IN_MEMORY environment variable as a string. Currently, in the ChromaDataStore.__init__ method (specifically, the in_memory variable), it directly relies on this value for decision-making(e.g.: if in_memory: ...). However, since any non-empty string is evaluated as True in the if statement, it results in the program attempting to use in_memory storage even when the CHROMA_IN_MEMORY environment variable is set to "false".

@zanghu zanghu changed the title in_memory always True in chroma_datastore in_memory always got True in chroma_datastore Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant