Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that requiredOptions work within imperativeConfiguration #57

Open
nickevansuk opened this issue Jan 22, 2020 · 1 comment
Open

Ensure that requiredOptions work within imperativeConfiguration #57

nickevansuk opened this issue Jan 22, 2020 · 1 comment
Assignees
@henryaddison

Comments

@nickevansuk
Copy link
Contributor

Check that requiredOptions works within imperativeConfiguration, e.g. Order.json#L110
@nickevansuk nickevansuk changed the title Ensure that requiredOptions work within imperativeConfiguration data-models: Ensure that requiredOptions work within imperativeConfiguration Jan 22, 2020
@nickevansuk nickevansuk changed the title data-models: Ensure that requiredOptions work within imperativeConfiguration Ensure that requiredOptions work within imperativeConfiguration Jan 22, 2020
@nickevansuk nickevansuk changed the title Ensure that requiredOptions work within imperativeConfiguration Validator: Ensure that requiredOptions work within imperativeConfiguration Jan 27, 2020
@nickevansuk nickevansuk changed the title Validator: Ensure that requiredOptions work within imperativeConfiguration Ensure that requiredOptions work within imperativeConfiguration Jan 27, 2020
@henryaddison henryaddison self-assigned this Feb 18, 2020
@henryaddison
Copy link
Contributor

I believe this is already covered by RequiredOptionalFieldsRule - https://github.com/openactive/data-model-validator/blob/master/src/rules/core/required-optional-fields-rule.js#L37

See specs that test this https://github.com/openactive/data-model-validator/blob/master/src/rules/core/required-optional-fields-rule-spec.js#L22-L36 and https://github.com/openactive/data-model-validator/blob/master/src/rules/core/required-optional-fields-rule-spec.js#L140-L181

@nickevansuk nickevansuk transferred this issue from openactive/openactive-test-suite Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryaddison henryaddison

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryaddison @nickevansuk