Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facilityType ID/prefLabel are not checked against the canonical list #414

Open
lukehesluke opened this issue Jun 29, 2022 · 0 comments
Open

Comments

@lukehesluke
Copy link
Contributor

lukehesluke commented Jun 29, 2022

How to reproduce

  1. Go to the FacilityUse example in validator
  2. Change facilityType[0].@id to https://doesntexist9127301.com
  3. Change facilityType[0].prefLabel to Tennis Courp
  4. Run "Validate"
  5. See that it doesn't register the changes as errors, even though this is now an incorrect facilityType

What it should do

Validator should act as it does for activity. If you load up the SessionSeries example, and change the activity[0].@id and activity[0].prefLabel to incorrect values, an error message is shown

It's worth noting, however, that, even for activity, the error checking is incomplete. If you only change the prefLabel, e.g. to Schbodypump™, there will be no error.

Therefore, a stretch goal of this task might be to have the activity and facilityType validation check that the prefLabel is correct for the ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant