Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail-safe date and language visibility if High Contrast is set #682

Open
cH3n7i opened this issue Sep 4, 2019 · 2 comments
Open

Fail-safe date and language visibility if High Contrast is set #682

cH3n7i opened this issue Sep 4, 2019 · 2 comments

Comments

@cH3n7i
Copy link
Contributor

cH3n7i commented Sep 4, 2019

Is your feature request related to a problem? Please describe.
With several images being bright, release dates and language are not visible - let's make sure we take care of High Contrast.

Screenshot 2019-09-04 at 19 53 57

Describe the solution you'd like
When in High Contrast mode we should make could put a subtle background color to make sure there is a contrast.

Affected Component
CourseListViewController

@mathebox
Copy link
Member

I totally agree! The gradient on the bottom of the image does not always work so well. But I also think that this problem is not restricted to the high contrast mode. We should make sure that the text is readable all the time.

To be honest, I don't have a good looking solution for this yet. The options I see are the following:

  • Remove the date and language label from the CourseCell
    • Here the user loses essential information, doesn't he?
  • Move the date and language label below the image
    • With this option, we would increase the height of the CourseCell even more.
  • Move the label in a UIVisualEffectView
    • This might look a bit strange

Some things we check before moving on:

  • How does Apple handle this issue in its image-based apps? What are other big players doing?
  • Should the layout of the CourseCell differ for the usage on the dashboard and the course list?
  • Does the Android app show the course date and language in the course list? @tobiasrohloff
    • The web application does display these values in the course list

@tobiasrohloff
Copy link

A course card on Android looks like this:

IMAGE 2019-09-10 17:37:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants