Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enrich super admin and admin role by assigning their respective roles #2143

Open
Lanhild opened this issue May 9, 2024 · 2 comments
Open

Comments

@Lanhild
Copy link
Contributor

Lanhild commented May 9, 2024

There's been a new super admin role since the 0.1.123 version to restrict user actions to other admins.

It'd be useful if model downloading/deletion were restricted to the super admin.

image

@Lanhild
Copy link
Contributor Author

Lanhild commented May 9, 2024

After being confused by the 2nd line;

User action buttons from the admin panel are now disabled for users with admin roles.

I discussed with another contributor about this, and thought some modifications would be necessary for this new "super admin" role

  • Make the super admin role assignable by other super admins
  • Super admin should be the only one able to see others chats, modify roles or modify users
  • "Normal" admins would preserve their current permissions, minus the latter

Below is a transcript of our conversation.

image
image

@Lanhild
Copy link
Contributor Author

Lanhild commented May 9, 2024

@tjbck here's a link to a table describing the needs/permissions for this "Super Admin" role.

It restricts "Admin" permissions a lot, but it makes sense in the way that the "Super Admin"(s) exists, and mitigates the risk of a bad actor compromising one's WebUI instance.

https://docs.google.com/spreadsheets/d/1Zb6_aC3h-wPb7K7eVxFYO9PV0k4PAlIUKM0AxRQd_dc/edit?usp=sharing

Anyhow, once we have the role for that, it'll be easier in the future to allow/restrict other features.

@Lanhild Lanhild changed the title feat: Enrich super admin role by restricting model downloading feat: Enrich super admin and admin role by assigning their respective roles May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant