Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveRecord 7.1 Instrument transaction.active_record #833

Open
arielvalentin opened this issue Jan 23, 2024 · 2 comments
Open

ActiveRecord 7.1 Instrument transaction.active_record #833

arielvalentin opened this issue Jan 23, 2024 · 2 comments
Labels
help wanted Extra attention is needed instrumentation keep Ensures stale-bot keeps this issue/PR open

Comments

@arielvalentin
Copy link
Collaborator

ActiveRecord 7.1 introduced a new notification that instruments Database Transactions and I think we should include it in our instrumentation :)

https://github.com/rails/rails/blob/v7.1.1/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb#L93
@arielvalentin arielvalentin added help wanted Extra attention is needed instrumentation labels Jan 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Feb 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
@arielvalentin arielvalentin reopened this Mar 24, 2024
@github-actions github-actions bot removed the stale Marks an issue/PR stale label Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Apr 24, 2024
@arielvalentin arielvalentin added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed instrumentation keep Ensures stale-bot keeps this issue/PR open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arielvalentin