Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tracing for Caffeine Cache #11322

Open
doppleware opened this issue May 9, 2024 · 3 comments
Open

Support tracing for Caffeine Cache #11322

doppleware opened this issue May 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@doppleware
Copy link

Is your feature request related to a problem? Please describe.

We want to see in our tracing when the cache is being used, currently this is not recorded,

Describe the solution you'd like

If there is a fear it might be too verbose it can be off by default

Describe alternatives you've considered

Didn't find any alternatives

Additional context

No response

@doppleware doppleware added enhancement New feature or request needs triage New issue that requires triage labels May 9, 2024
@laurit
Copy link
Contributor

laurit commented May 9, 2024

I suspect that this would have limited usefulness because of potentially creating a very large amount of spans and also because tracing is probably much more expensive than the cache operations themself. Have you considered building an extensions for this yourself?
Collecting metrics would make more sense for caches.

@laurit laurit added the needs author feedback Waiting for additional feedback from the author label May 9, 2024
@doppleware
Copy link
Author

Hey @laurit that makes sense. However, this is for dev/test scenarios where we are not necessarily looking at the performance aspect. So more from an analytics and flow point of view.
We can also add support via an extension I would guess. It just seems like a more real way to represent what is happening (similar to calls to JDBC)

@github-actions github-actions bot removed the needs author feedback Waiting for additional feedback from the author label May 9, 2024
@trask
Copy link
Member

trask commented May 9, 2024

hi @doppleware, I agree with @laurit that tracing for a local cache is probably not something we'd want to implement in this repository (unlike for example tracing for a remote cache like redis)

@steverao steverao removed the needs triage New issue that requires triage label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants