Can we omit this annotation entirely if .Values.admissionWebhooks.certManager.enabled=false instead of setting it to none?

[TylerHelmuth]

          Can we omit this annotation entirely if `.Values.admissionWebhooks.certManager.enabled=false` instead of setting it to `none`?

Originally posted by @TylerHelmuth in #1175 (comment)

[suyash-811]

Hey, i would like to work on this issue.

[TylerHelmuth]

@suyash-811 Great, we should wait until #1176 is merged.

[suyash-811]

Just saw that the PR merged. I'll update the helm template to add the cert-manager annotation if .Values.admissionWebhooks.certManager.enabled=false

[suyash-811]

I took a look at the template admission-webhooks/operator-webhook-with-cert-manager.yaml. There is an ifblock at the start of the file which also uses the same field from the values file to generate the Webhook configurations (.Values.admissionWebhooks.certManager.enabled).

opentelemetry-helm-charts/charts/opentelemetry-operator/templates/admission-webhooks/operator-webhook-with-cert-manager.yaml

Lines 1 to 6 in 870f231

	{{- if and (.Values.admissionWebhooks.create) (.Values.admissionWebhooks.certManager.enabled) }}
	apiVersion: admissionregistration.k8s.io/v1
	kind: MutatingWebhookConfiguration
	metadata:
	annotations:
	cert-manager.io/inject-ca-from: {{ include "opentelemetry-operator.webhookCertAnnotation" . }}

Thus, i am a bit unsure if this is the file that really needs the change, as the file isnt rendered at all when the cert-manager admissionWebhook is disabled. Or maybe i got something wrong? Either way, looking forward to some feedback!

[TylerHelmuth]

@suyash-811 Look for the other places that use the opentelemetry-operator.webhookCertAnnotation helper template. I believe instead of setting none we can add more template logic to conditionally add the annotation.

This is going to break make update-operator-crds and make check-operator-crds and maybe shouldn't be done until we've got a better way to keep the CRD templates up to date.

[suyash-811]

Ah i see. I'll prepare a PR for this. It can be merged once CRD management is done.