Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Business Metric Service #852

Conversation

austinlparker
Copy link
Member

@austinlparker austinlparker commented Apr 25, 2023

Changes

Closes #850

This adds a Java service that deliberately does not enable OpenTelemetry instrumentation at build time. It only takes a dependency on the OpenTelemetry API to create a metric. The intended use of this service is to demonstrate the OpenTelemetry Operator's Instrumentation CRDs (as well as API-only usage of OpenTelemetry).

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@austinlparker austinlparker requested a review from a team as a code owner April 25, 2023 02:24
@julianocosta89
Copy link
Member

Are we adding a new java service?
Wouldn't be better to allow users to enable/disable instrumentation on the services we already have?

@cartersocha
Copy link
Contributor

I'm hesitant to add to the existing resource requirements given the kubecon feedback for a smaller footprint

@julianocosta89
Copy link
Member

I'm hesitant to add to the existing resource requirements given the kubecon feedback for a smaller footprint

same here

@austinlparker
Copy link
Member Author

I don't anticipate this being used in a local deployment -- my 0.02 is that we should address the resource issue by creating a "minimal" set of services to be run locally while allowing for a larger set to be run in "production" deployments

@austinlparker
Copy link
Member Author

The advantage of adding a net new service here is that it's a terminal/leaf service, ensuring that disabling the service or running it without instrumentation doesn't impact the rest of the deployment.

@puckpuck
Copy link
Contributor

Let's create a plan to have minimal and more expansive deployment scenarios before we add anything new. Something we can discuss in detail at the next SIG meeting.

@cartersocha
Copy link
Contributor

Can merge post simple+ demo

@austinlparker
Copy link
Member Author

FYI I'm building this in my own repo and publishing it in the meantime - https://github.com/austinlparker/otel-demo-business-metrics

@austinlparker
Copy link
Member Author

I'll be able to publicly share the demo flow for this in a few weeks

@github-actions
Copy link

github-actions bot commented May 9, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 9, 2023
@puckpuck puckpuck removed the Stale label May 13, 2023
@puckpuck
Copy link
Contributor

After we get #872 finished and merged, we can look to move this as an additional service in an optional module/preset.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 16, 2023
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Service: Business Metric Processor
5 participants