Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Global img provider #1571

Merged
merged 10 commits into from May 15, 2024

Conversation

klucsik
Copy link
Contributor

@klucsik klucsik commented May 13, 2024

Changes

Fixes #1570 by moving the image loader to a global scope. This needs a newer next.js version, so some version bumps are also made.
reference on imageloader: https://nextjs.org/docs/pages/api-reference/next-config-js/images

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the [docs][]
  • Appropriate Helm chart updates in the [helm-charts][]

@github-actions github-actions bot added the helm-update-required Requires an update to the Helm chart when released label May 13, 2024
@klucsik klucsik marked this pull request as ready for review May 14, 2024 06:37
@klucsik klucsik requested a review from a team as a code owner May 14, 2024 06:37
@klucsik klucsik changed the title Global img provider [Frontend] Global img provider May 14, 2024
Copy link
Member

@mviitane mviitane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs fine, problem fixed!

Screenshot 2024-05-14 at 15 04 06

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this @klucsik!

@julianocosta89 julianocosta89 merged commit a82287d into open-telemetry:main May 15, 2024
30 checks passed
@klucsik klucsik deleted the global-img-provider branch May 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[frontend] images not showing in shopping cart popup
3 participants