-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Most char API should use Copy instead of Ref #241
Labels
Comments
bors bot
added a commit
that referenced
this issue
Jul 24, 2019
237: travis: Enable Windows and MacOS builds r=behnam a=behnam <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/237) <!-- Reviewable:end --> 252: Clippy fixes and changing refs to Copy r=CAD97 a=JamesHinshelwood Updated clippy allows from `cfg_attr` to proc-macro style. Fixed #241 + more - Changed a few `impl`s to take `self` instead of `&self`, when they are `Copy` types. `cargo clippy` should run without any warnings now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/252) <!-- Reviewable:end --> Co-authored-by: Behnam Esfahbod <[email protected]> Co-authored-by: JamesHinshelwood <[email protected]>
bors bot
added a commit
that referenced
this issue
Jul 24, 2019
252: Clippy fixes and changing refs to Copy r=CAD97 a=JamesHinshelwood Updated clippy allows from `cfg_attr` to proc-macro style. Fixed #241 + more - Changed a few `impl`s to take `self` instead of `&self`, when they are `Copy` types. `cargo clippy` should run without any warnings now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/252) <!-- Reviewable:end --> Co-authored-by: JamesHinshelwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Most functions taking
char
as input, specially those takingself
with a small struct only having one or twochar
, should be migrated to takeself
instead of&self
.Some of the clippy warnings:
The text was updated successfully, but these errors were encountered: