Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update legacy cipher setting #1357

Closed

Conversation

joko-sastriawan
Copy link

  • allow legacy cipher when MPS runs with backward compatibility

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Allow legacy cipher to be enabled when using Node JS version > 16.

Anything the reviewer should know when reviewing this PR?

Due to the nature of the changes, test is performed on an actual deployment.

Tested using

curl -k --tls-max 1.0 --ciphers 'AES128-SHA:AES256-SHA' https://mpshost:4433/

Tested using real hardware (NUC5i5MHYE-Broadwell) by:

  • manually updating MPSCerts ciphers in vault and reload mps service
  • new stack deployment with updated mps code
    CIRA on AMT 10 could connect on both cases.

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

- allow legacy cipher when MPS runs with backward compatibility
@joko-sastriawan joko-sastriawan changed the title Update legacy cipher setting fix: Update legacy cipher setting Mar 14, 2024
@joko-sastriawan joko-sastriawan changed the title fix: Update legacy cipher setting fix: update legacy cipher setting Mar 14, 2024
@rsdmike
Copy link
Member

rsdmike commented Sep 10, 2024

closed as is addressed in #1619

@rsdmike rsdmike closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants