Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to flush output via newline in between tests #1347

Closed
onsi opened this issue Feb 2, 2024 · 7 comments
Closed

Make it possible to flush output via newline in between tests #1347

onsi opened this issue Feb 2, 2024 · 7 comments

Comments

@onsi
Copy link
Owner

onsi commented Feb 2, 2024

Some CI systems only flush output when a newline is observed. This makes it hard to see Ginkgo's progress when running without -v. A new mode that forces Ginkgo to emit a newline between each spec report (even if that report is just "o") would resolve this.

/cc @pohly

@pohly
Copy link
Contributor

pohly commented Feb 3, 2024

This is the gist of it. Note that we haven't actually verified that a newline will help, but it seems likely.

While you are at it, a mode where not even the o or S gets printed might also be useful. When I run -focus=one-particular-test, the screen fills up with S characters simply because we have so many tests in the Kubernetes E2E suite.

@pohly
Copy link
Contributor

pohly commented Feb 4, 2024

Or make it so that just the S gets skipped (pun intended). The o is useful when running a few tests.

@onsi
Copy link
Owner Author

onsi commented May 21, 2024

sigh - it only took 3 months but --silence-skips and --force-newlines are both now available on master. i'll be cutting a release shortly. please give it a try when you have time and lemme know if it helps.

@onsi
Copy link
Owner Author

onsi commented May 21, 2024

2.18.0 is out and includes this

@onsi onsi closed this as completed May 21, 2024
@onsi
Copy link
Owner Author

onsi commented May 21, 2024

woops - didn't mean to close it!

@onsi onsi reopened this May 21, 2024
pohly added a commit to pohly/kubernetes that referenced this issue May 22, 2024
The most interesting aspect of the new Ginkgo is tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.
@pohly
Copy link
Contributor

pohly commented May 22, 2024

This works as expected and does indeed help with watching progress in Prow. Thanks!

I think this can be closed.

pohly added a commit to pohly/kubernetes that referenced this issue May 22, 2024
The most interesting aspect of the new Ginkgo is tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.
pohly added a commit to pohly/kubernetes that referenced this issue May 22, 2024
The most interesting aspect of the new Ginkgo is tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

The latest pprof added an indirect dependency on github.com/mailru/easyjson
when adding a complex integration test. This does not affect Kubernetes and
thus can be ignored.
@onsi
Copy link
Owner Author

onsi commented May 22, 2024

wonderful, glad to hear it!

@onsi onsi closed this as completed May 22, 2024
pohly added a commit to pohly/kubernetes that referenced this issue May 27, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).
pohly added a commit to pohly/kubernetes that referenced this issue May 27, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).
k8s-publishing-bot pushed a commit to kubernetes/apimachinery that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/api that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/client-go that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/code-generator that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/component-base that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/component-helpers that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kms that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/apiserver that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kube-aggregator that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/sample-apiserver that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/sample-controller that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/apiextensions-apiserver that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/metrics that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/cli-runtime that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/sample-cli-plugin that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kube-proxy that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/cri-api that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/cri-client that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kubelet that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kube-scheduler that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/controller-manager that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/cloud-provider that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kube-controller-manager that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/cluster-bootstrap that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/csi-translation-lib that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/mount-utils that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/kubectl that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/pod-security-admission that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/dynamic-resource-allocation that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
k8s-publishing-bot pushed a commit to kubernetes/endpointslice that referenced this issue May 28, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).

Kubernetes-commit: 37e2dd6857084a172ef5210caee1fefa8dd8159a
YamasouA pushed a commit to YamasouA/kubernetes that referenced this issue Jul 24, 2024
Ginkgo v2.18.0 allows tweaking the output so that
it's easier to follow while a job runs in
Prow (onsi/ginkgo#1347). Using this in
hack/ginkgo-e2e.sh will follow in a separate commit.

Gomega gets bumped to the latest release to keep it up-to-date.

Ginkgo v1.19.0 adds support for --label-filter with labels that represent
sets (like our Feature:<Foo>).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants