Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interest in runner improvements #1342

Open
ebabani opened this issue Jan 23, 2024 · 1 comment
Open

Interest in runner improvements #1342

ebabani opened this issue Jan 23, 2024 · 1 comment

Comments

@ebabani
Copy link
Contributor

ebabani commented Jan 23, 2024

After using the vite test runner there are some features we miss:

  • Running in watch mode, and being able to re-run all suites under watch (press "a" in watch mode). It cancels any already running tests and re-runs all suites.
  • Filtering test files directly from watch mode (press "p", type file name)
  • Ability to re-run all failing tests when under watch mode, not just those touched (press "f")

Any interest in adding these or similar to the ginkgo runner? Of the above the first item would be the simplest and highest value, being able to re-run all suites under watch, and let devs stay in watch mode.

@onsi
Copy link
Owner

onsi commented Jan 23, 2024

hey @ebabani these are cool ideas to be sure. i could imagine extending Ginkgo's existing watch mode and you're right that the first one would be relatively easy. For filtering I usually just add an F in front of the Its and Describes that I care about. And the ability to re-run just failing specs is an interesting one. That would definitely be a heavier lift.

This seems adjacent to an idea I've long considered which is to implement a browser-based test runner that allows for much richer interactions with Ginkgo via a sane interface. Lots of cool things could happen here including better feedback during parallel test runs, the ability to quickly filter views of test runs, to rerun/watch specific tests, etc. I don't know if/when it'll happen and everytime I get close to pulling taking the project seriously I remind myself that I'm, personally, ~95% happy with the current CLI experience and wonder whether a web interface would be worth the effort after all :)

But if you'd like to explore extending the current implementation of ginkgo watch and adding support for directing flow via input keys that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants