Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Add the new FCL discovery mechanism to Kitty Items #213

Closed
srinjoyc opened this issue Feb 1, 2022 · 3 comments
Closed

Add the new FCL discovery mechanism to Kitty Items #213

srinjoyc opened this issue Feb 1, 2022 · 3 comments
Assignees
Labels
blocked Developer Tool Team feature New functionality that satisfies a specific use case or set of use cases feedback

Comments

@srinjoyc
Copy link
Contributor

srinjoyc commented Feb 1, 2022

Currently, when Kitty Items uses FCL discovery, it shows both Ledger & Blocto. Ledger does not work with Kitty items and should be removed as an option.

This can be done by updating to the latest FCL which will automatically remove ledger but will only show Blocto. To avoid this we can use the new FCL discovery mechanism to replace the log in button programmatically with the discovery API. See link.

@srinjoyc srinjoyc added feature New functionality that satisfies a specific use case or set of use cases feedback labels Feb 1, 2022
@srinjoyc srinjoyc added this to the Kitty Items MVP milestone Feb 1, 2022
@alxflw alxflw removed this from the Kitty Items MVP milestone Feb 24, 2022
@10thfloor
Copy link
Contributor

This has been removed pending further improvements by @chasefleming
cc @kerrywei @srinjoyc Can we move this to closed or backlog?

@chasefleming
Copy link
Member

Just want to note the programmatic way of using Discovery API over UI is not the only way to remove Ledger. Upgrading FCL will also remove Ledger from the UI modal unless explicitly told to include it in the config.

@alxflw alxflw added the blocked label Mar 3, 2022
@10thfloor
Copy link
Contributor

10thfloor commented Mar 8, 2022

This issue has been removed from the sprint, as it is not required for KittyItems v2 launch.
It was removed to free up capacity to work on features for v2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked Developer Tool Team feature New functionality that satisfies a specific use case or set of use cases feedback
Projects
None yet
Development

No branches or pull requests

6 participants