Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of redirection in the searchform.php to the target page #932

Open
3 tasks
fredericalpers opened this issue Oct 17, 2024 · 9 comments
Open
3 tasks
Assignees
Labels
component: property list Issue, Pull Request or Discussion related to property lists feature New feature QA Issue or Pull request that is in review

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Oct 17, 2024

Selection of redirection in the searchform.php to the target page

User Story

As an administrator or developer of a property website, I want to add a dropdown element in the settings page for the searchform.php that allows me to select a target page for search results. The selected page should automatically populate the form action attribute, so users are redirected to the correct property listing or results page without requiring manual code changes.

Task/Requirements

  • A dropdown (select element) should be integrated into the settings for the searchform.php to allow the administrator to choose between different target pages for search results.
  • The dropdown must be implemented so that the selected target page automatically updates the action attribute of the search form.
  • Once the user submits a search query on the frontend, they are redirected to the appropriate page without requiring any manual template modifications.

260985869-6c8e5d37-e71f-40cb-9fdc-408f59e46b23

260985891-adfc175f-7c6d-4d9a-804a-52a48de31225

@fredericalpers fredericalpers added feature New feature component: property list Issue, Pull Request or Discussion related to property lists labels Oct 17, 2024
@fredericalpers fredericalpers added this to the v5.8 milestone Oct 17, 2024
@yeneastgate
Copy link
Contributor

@fredericalpers I see there's an old issue I've already investigated (see issue #613). Is this issue similar to that one?

@fredericalpers
Copy link
Member Author

@yeneastgate you are right. the only difference is that this Issue here is "Step 1" without further additional changes to the behaviour besides the implementation of the forwarding. I will close the other issue, thank you :)

@yeneastgate
Copy link
Contributor

yeneastgate commented Oct 18, 2024

@fredericalpers I have a few points I need to confirm with you:

  1. In the "Select page" dropdown menu, will the list display "pages using shortcode" from the ListView?

  2. When a user submits a search query on the frontend, they will be redirected to the "selected page" in the admin panel, including the searched parameters in the search form and displaying the corresponding estate search results.

  3. If the search form includes a "city" field but the selected page does not have a "city" field, the search should still function correctly based on the "city" field, even if the results are not shown in the estate information.

  4. When searching in the search form, will the filters in "Filters & Records" depend on the Forwarding page? Because currently, if the "Filters & Records" of the search form and the "Filters & Records" of the Forwarding page are different, it will produce different results when searching.
    image

@fredericalpers
Copy link
Member Author

@yeneastgate

In the "Select page" dropdown menu, will the list display "pages using shortcode" from the ListView?

We want to keep it simple and display all created pages.

When a user submits a search query on the frontend, they will be redirected to the "selected page" in the admin panel, including the searched parameters in the search form and displaying the corresponding estate search results.
If the search form includes a "city" field but the selected page does not have a "city" field, the search should still function correctly based on the "city" field, even if the results are not shown in the estate information.

Correct, however the customer has to mark the fields as filterable/show in search on the searchform and the propertylist themselves. if the city field is not made filterable the search does not have to work with these fields.

When searching in the search form, will the filters in "Filters & Records" depend on the Forwarding page? Because currently, if the "Filters & Records" of the search form and the "Filters & Records" of the Forwarding page are different, it will produce different results when searching.

Thats okay, since the customer has to make sure the searchform and the corresponding property lists are set up properly.

We simply want to give the customer the possibility to set up the forwarding with the form action without having to have coding knowledge and having to customize the templates.

@yeneastgate
Copy link
Contributor

We want to keep it simple and display all created pages.

@fredericalpers If it's the pages that have been created, will it display both the pages with the shortcode address and the form, right?

@yeneastgate
Copy link
Contributor

image

@fredericalpers Could you send me the link to the documentation so I can add it?

@fredericalpers
Copy link
Member Author

@yeneastgate this is our current documentation: https://wp-plugin.onoffice.com/de/

@yeneastgate
Copy link
Contributor

@fredericalpers Please take a look at my demo video and let me know your opinions. Thank you!

cmt.mp4

@fredericalpers
Copy link
Member Author

Seems good to me! I will review this as soon as possible! :) Thank you

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Oct 25, 2024
@fredericalpers fredericalpers removed this from the v5.8 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: property list Issue, Pull Request or Discussion related to property lists feature New feature QA Issue or Pull request that is in review
Projects
None yet
Development

No branches or pull requests

2 participants