Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Link Fields as Actual Links in Frontend #920

Open
4 tasks done
fredericalpers opened this issue Oct 4, 2024 · 4 comments · May be fixed by #930
Open
4 tasks done

Display Link Fields as Actual Links in Frontend #920

fredericalpers opened this issue Oct 4, 2024 · 4 comments · May be fixed by #930
Assignees
Labels
component: adress list detail page Issue & Pull Request or Discussion related to adress list detail page component: property detail page Issue, Pull Request or Discussion related to property detail page QA Issue or Pull request that is in review UI/UX Issue, Pull Request or Discussion related to UI/UX

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Oct 4, 2024

Display Link Fields as Actual Links in Frontend

Introduction

Currently, fields of the type "link" are displayed as plain text in the frontend, without functioning as actual clickable hyperlinks.

User Story

As a user, I want link fields (e.g. Socialmedia) to be rendered as clickable hyperlinks in the frontend so that I can easily navigate to external resources by clicking on them. The links should open in a new tab to preserve my current browsing session, and security attributes should be added to prevent security vulnerabilities.

Task / Requirements

  • Fields of the type "link" should be rendered as actual clickable hyperlinks (HTML elements) in the frontend.
  • The target="_blank" attribute should be added to the rendered link, so that when a user clicks on it, the link opens in a new browser tab.
  • Add the rel="nofollow noopener" attributes to the rendered link to improve security.
  • Links should have proper aria-labels if necessary, to ensure screen readers announce the links appropriately.
@fredericalpers fredericalpers added UI/UX Issue, Pull Request or Discussion related to UI/UX component: property detail page Issue, Pull Request or Discussion related to property detail page component: adress list detail page Issue & Pull Request or Discussion related to adress list detail page labels Oct 4, 2024
@fredericalpers fredericalpers added this to the v5.8 milestone Oct 4, 2024
@yeneastgate yeneastgate self-assigned this Oct 8, 2024
@yeneastgate
Copy link
Contributor

@fredericalpers
Currently, I check on onOffice enterprise, the fields with "type = link" the API response is "type=text"
=> Please update the API to return the correct "type=link" for fields of the type "link"
image
image

@fredericalpers
Copy link
Member Author

fredericalpers commented Oct 9, 2024

@yeneastgate please implement the the <a> and the attributes for the following fields:

Module: Contacts management Category: Contact

  • Homepage

Module: Contacts management Category: Social media

  • facebook
  • twitter
  • youtube
  • instagram
  • linkedin
  • xing
  • tiktok
  • pinterest

Module: Contacts management Category: Administration:

  • bewertungslinkWebseite

@yeneastgate
Copy link
Contributor

@yeneastgate please implement the the <a> and the attributes for the following fields:

@fredericalpers I got it, thanks!

@yeneastgate
Copy link
Contributor

@fredericalpers Please take a look at my demo video and let me know your opinions. Thank you!

920.mp4

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Oct 17, 2024
@fredericalpers fredericalpers removed this from the v5.8 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: adress list detail page Issue & Pull Request or Discussion related to adress list detail page component: property detail page Issue, Pull Request or Discussion related to property detail page QA Issue or Pull request that is in review UI/UX Issue, Pull Request or Discussion related to UI/UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants