Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanently Marked Required Fields and Correct Local Area Search in Applicant Forms #868

Open
4 of 5 tasks
fredericalpers opened this issue Jul 25, 2024 · 7 comments · May be fixed by #879
Open
4 of 5 tasks

Permanently Marked Required Fields and Correct Local Area Search in Applicant Forms #868

fredericalpers opened this issue Jul 25, 2024 · 7 comments · May be fixed by #879
Assignees
Labels
component: interest form Issue, Pull Request or Discussion related to interest forms QA Issue or Pull request that is in review

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Jul 25, 2024

Permanently Marked Required Fields and Correct Local Area Search in Applicant Forms

Introduction

In #641, we made the required field checkboxes permanently marked and non-deselectable. However, this seems to have only been implemented for the property list. For applicantform.php, the permanently marked required fields are missing and are not made non-deselectable. Additionally, in applicantsearchform.php, the radius search looks completely different and needs to be corrected.

User Story

As a real estate agent, I want the required fields in the applicantform.php and applicantsearchform.php forms to be permanently marked and non-deselectable. Additionally, I want the local area search in applicantsearchform.php to be correctly displayed and functional so that users have a seamless and consistent experience.

By implementing this user story, we ensure that the usability and functionality of the applicant forms in the real estate portal are improved.

Task / Requirements

Required Fields in applicantform.php:

  • All required fields are marked with checked and disabled attributes.Us
  • Users cannot deselect the marked required fields.

Local area search in applicantsearchform.php:

  • The functionality should resemble the same as the other geoPosition
  • All required fields are marked with checked and disabled attributes.Us
  • Users cannot deselect the marked required fields.

geoPosition-applicantsearch (1)
geoPosition-interest-form (1)
geoPosition-propertylist (1)

@fredericalpers fredericalpers added the component: interest form Issue, Pull Request or Discussion related to interest forms label Jul 25, 2024
@fredericalpers fredericalpers added this to the v5.6 milestone Jul 25, 2024
@dai-eastgate
Copy link
Contributor

@fredericalpers After investigating this task, I need to confirm the following:

  • In applicantsearchform: there are 4 fields
    image
  • In applicantform: there are 5 fields
    image

=> Which fields are required to be checked and disabled in two Forms(Interest Form, Application Search Form)?

  • Additionally, in applicantsearchform.php, the radius search looks completely different and needs to be corrected.

    Currently, the Applicant Search Form does not have a select radius section. Would you like to add select radius section to Admin Applicant Search Form?

image

@dai-eastgate dai-eastgate self-assigned this Aug 8, 2024
@fredericalpers
Copy link
Member Author

@dai-eastgate the fields (geoPosition) should be the same as in the property list. All 5 values, country, city, zip code, street and radius must be present. The mandatory fields should be the same as in the property list. Furthermore, the same info text must be visible.

@dai-eastgate
Copy link
Contributor

@fredericalpers I checked and found that there is a restriction on the radius checkbox from being generated in the Application Search Form. Could you please confirm if you would like me to enable this feature in the Application Search Form? I want to make sure I understand your intent correctly before making any changes.
image

@dai-eastgate
Copy link
Contributor

@fredericalpers I rechecked commit code and found that this commit 38014b6 has already implemented radius suppression in the Applicant Search Form. Please take a look at this commit and let me know your opinion. Thank you!

@fredericalpers
Copy link
Member Author

@fredericalpers I rechecked commit code and found that this commit 38014b6 has already implemented radius suppression in the Applicant Search Form. Please take a look at this commit and let me know your opinion. Thank you!

@dai-eastgate please leave it as it is then, thank you for doing your due diligence! :)

@dai-eastgate
Copy link
Contributor

@fredericalpers I got it, I will continue to implement this issue

@dai-eastgate
Copy link
Contributor

@fredericalpers I have implemented it. Here is evidence. Please check and let me know your opinion. Thank you!

868_demo.mp4

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Aug 15, 2024
@fredericalpers fredericalpers removed this from the v5.6 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interest form Issue, Pull Request or Discussion related to interest forms QA Issue or Pull request that is in review
Projects
None yet
2 participants