Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shortcode Recognition for Detail Pages in WP Bakery Builder #852

Open
2 of 3 tasks
fredericalpers opened this issue Jul 2, 2024 · 5 comments
Open
2 of 3 tasks
Assignees
Labels
bug Indicates an unexpected problem or unintended behaviour component: property detail page Issue, Pull Request or Discussion related to property detail page QA Issue or Pull request that is in review

Comments

@fredericalpers
Copy link
Member

fredericalpers commented Jul 2, 2024

Fix Shortcode Recognition for Detail Pages in WP Bakery Builder

User Story

As a user of the onOffice WordPress plugin, I want the shortcode for detail pages to be recognized correctly when using the "Raw HTML" or "Code" elements in WP Bakery Builder, so that I can utilize these elements without issues.

Customers have reported that the shortcode for detail pages is not recognized when using the "Raw HTML" or "Code" elements in WP Bakery Builder. However, the shortcode works correctly when using the normal text element. This bug needs to be investigated and fixed to ensure that the shortcode functions properly regardless of the WP Bakery element used.

By addressing this bug, users will be able to utilize the detail page shortcode within any WP Bakery Builder element, improving the flexibility and usability of the onOffice WordPress plugin.

Tasks / Requirements

  • The shortcode for detail pages should be recognized and rendered correctly when placed inside the "Raw HTML" element in WP Bakery Builder.
  • The shortcode for detail pages should be recognized and rendered correctly when placed inside the "Code" element in WP Bakery Builder.
  • Ensure that the shortcode functionality is consistent across different WP Bakery elements, including "Raw HTML," "Code," and normal text elements.
@fredericalpers fredericalpers added bug Indicates an unexpected problem or unintended behaviour component: property detail page Issue, Pull Request or Discussion related to property detail page labels Jul 2, 2024
@fredericalpers fredericalpers added this to the v4.26 milestone Jul 2, 2024
@yeneastgate
Copy link
Contributor

@fredericalpers After investigate, I found that saving the content of the detail page does not work because the post content of Raw HTML is being encoded, which prevents adding Dynamic Rewrite Rules and causes the detail page to not display.
image

  • The shortcode for detail pages should be recognized and rendered correctly when placed inside the "Code" element in WP Bakery Builder.

image

Currently, I see that only Raw HTML and Raw JS are being encoded when saved. Can you clarify which Code element you are referring to?

@fredericalpers
Copy link
Member Author

@yeneastgate I think the Code element might have been a custom element. I can not find it anymore. You can ignore this.

@yeneastgate
Copy link
Contributor

@fredericalpers I got it, thank you

@yeneastgate
Copy link
Contributor

@fredericalpers I have implemented and here is video evidence:

bandicam.2024-07-24.14-24-32-885.mp4

Please check and let me know your opinion. Thanks!

@fredericalpers
Copy link
Member Author

@yeneastgate thank you, we will review this as soon as possible :)

@fredericalpers fredericalpers added the QA Issue or Pull request that is in review label Jul 24, 2024
@yeneastgate yeneastgate self-assigned this Jul 25, 2024
@fredericalpers fredericalpers removed this from the v5.5 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour component: property detail page Issue, Pull Request or Discussion related to property detail page QA Issue or Pull request that is in review
Projects
None yet
Development

No branches or pull requests

2 participants